Editor: Use hooks instead of HoCs for EditorNotices
#57772
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tyxla
added
[Priority] Low
|
Size Change: +2.4 kB (0%) Total Size: 1.7 MB
ℹ️ View Unchanged
|
ntsekouras
approved these changes
Jan 12, 2024
jsnajdr
reviewed
Jan 12, 2024
Mamaduka
approved these changes
Jan 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
This straightforward PR updates the
EditorNoticescomponent to use the@wordpress/datahooks instead of the HoCs.Why?
A micro-optimization to make the rendered component tree smaller.
How?
We're using the
useSelectanduseDispatchhooks instead of thewithSelectandwithDispatchhooks.Because we're removing a
withSelect, awithDispatchand acomposeinstance, this removes 3 levels of nesting.Testing Instructions
wp.data.dispatch( 'core/notices' ).createSuccessNotice('test!')in your console and verify a dismissable notice properly appears.wp.data.dispatch( 'core/notices' ).createSuccessNotice('test!', { isDismissible: false })in your console and verify a non-dismissable notice properly appears.Testing Instructions for Keyboard
None.
Screenshots or screencast
None.